drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ssriniva123 <...@git.apache.org>
Subject [GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...
Date Thu, 16 Jun 2016 21:54:29 GMT
Github user ssriniva123 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/518#discussion_r67431369
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
---
    @@ -189,39 +191,33 @@ private long currentRecordNumberInFile() {
       public int next() {
         writer.allocate();
         writer.reset();
    -
         recordCount = 0;
         ReadState write = null;
    -//    Stopwatch p = new Stopwatch().start();
    -    try{
    -      outside: while(recordCount < DEFAULT_ROWS_PER_BATCH) {
    -        writer.setPosition(recordCount);
    -        write = jsonReader.write(writer);
    -
    -        if(write == ReadState.WRITE_SUCCEED) {
    -//          logger.debug("Wrote record.");
    -          recordCount++;
    -        }else{
    -//          logger.debug("Exiting.");
    -          break outside;
    -        }
    -
    +    outside: while(recordCount < DEFAULT_ROWS_PER_BATCH){
    +    try
    +      {
    +            writer.setPosition(recordCount);
    --- End diff --
    
    Aman,
    maven checkstyle:checkstyle did not report any errors before I did my last
    check in. I have changed to reflect 2 spaces for indendation.
    
    On Thu, Jun 16, 2016 at 2:22 PM, Aman Sinha <notifications@github.com>
    wrote:
    
    > In
    > exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/JSONRecordReader.java
    > <https://github.com/apache/drill/pull/518#discussion_r67426381>:
    >
    > > -      outside: while(recordCount < DEFAULT_ROWS_PER_BATCH) {
    > > -        writer.setPosition(recordCount);
    > > -        write = jsonReader.write(writer);
    > > -
    > > -        if(write == ReadState.WRITE_SUCCEED) {
    > > -//          logger.debug("Wrote record.");
    > > -          recordCount++;
    > > -        }else{
    > > -//          logger.debug("Exiting.");
    > > -          break outside;
    > > -        }
    > > -
    > > +    outside: while(recordCount < DEFAULT_ROWS_PER_BATCH){
    > > +    try
    > > +      {
    > > +            writer.setPosition(recordCount);
    >
    > seems this is still doing indent of 4. We use 2 spaces (see
    > https://drill.apache.org/docs/apache-drill-contribution-guidelines/
    > scroll down to Step 2). Did it pass the mvn command line build without
    > checkstyle violations ?
    >
    > —
    > You are receiving this because you commented.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/drill/pull/518/files/56a16fe3f2bbd1554d65cef6faeaeb63ba41f9a2#r67426381>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe/ABsaHw_13TKQS-3mIEDhxkCiglpCBA3Sks5qMb6IgaJpZM4IzZkt>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message