drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...
Date Thu, 16 Jun 2016 17:41:24 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/518#discussion_r67390506
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java
---
    @@ -179,4 +181,28 @@ public void testNestedFilter() throws Exception {
             .sqlBaselineQuery(baselineQuery)
             .go();
       }
    +
    +
    + @Test // See DRILL-4653
    +  public void testSkippingInvalidJSONRecords() throws Exception {
    --- End diff --
    
    For both these tests could you pls use the testBuilder() framework ?  This is the recommended
way to write the unit tests .. you can see one of the other tests in this file.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message