drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #518: DRILL-4653.json - Malformed JSON should not stop th...
Date Thu, 16 Jun 2016 17:33:36 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/518#discussion_r67389073
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
    @@ -135,6 +135,9 @@
       BooleanValidator JSON_EXTENDED_TYPES = new BooleanValidator("store.json.extended_types",
false);
       BooleanValidator JSON_WRITER_UGLIFY = new BooleanValidator("store.json.writer.uglify",
false);
       BooleanValidator JSON_WRITER_SKIPNULLFIELDS = new BooleanValidator("store.json.writer.skip_null_fields",
true);
    +  String JSON_READER_SKIP_MALFORMED_RECORDS_FLAG = "store.json.reader.skip_malformed_records";
    --- End diff --
    
    Can you change this to 'skip_invalid_records' such that the name is somewhat consistent
with the future similar option in DRILL-3764.  In the future the json option would likely
be subsumed by the new global option. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message