drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request #507: DRILL-4690: CORS in REST API
Date Tue, 07 Jun 2016 00:42:23 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r65994192
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -111,7 +111,14 @@ drill.exec: {
         enabled: true,
         ssl_enabled: false,
         port: 8047
    -    session_max_idle_secs: 3600 # Default value 1hr
    +    session_max_idle_secs: 3600, # Default value 1hr
    +    cors: {
    +      enabled: true,
    --- End diff --
    
    I would default cors.enabled to false and/or set the access-cotrol-allow-origin to null.
Ideally, only the end user should be able to enable CORS for all sites. 
    Otherwise looks good to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message