drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request #514: DRILL-4694: CTAS in JSON format produces extraneous...
Date Sat, 04 Jun 2016 01:45:58 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/514#discussion_r65795093
  
    --- Diff: exec/java-exec/src/test/resources/json/ctas_alltypes_map_out.json ---
    @@ -0,0 +1,41 @@
    +{
    --- End diff --
    
    minor point: in TestJsonReader lately we were embedding the data generation in the code
instead of creating new files..but for small files like these I suppose this is fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message