Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0F744200AE4 for ; Wed, 11 May 2016 07:23:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 0E13F160A11; Wed, 11 May 2016 05:23:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4E86416098A for ; Wed, 11 May 2016 07:23:00 +0200 (CEST) Received: (qmail 16138 invoked by uid 500); 11 May 2016 05:22:59 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 16126 invoked by uid 99); 11 May 2016 05:22:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 May 2016 05:22:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E9CDBDFE04; Wed, 11 May 2016 05:22:58 +0000 (UTC) From: parthchandra To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request: DRILL-3474: Add implicit file columns support Content-Type: text/plain Message-Id: <20160511052258.E9CDBDFE04@git1-us-west.apache.org> Date: Wed, 11 May 2016 05:22:58 +0000 (UTC) archived-at: Wed, 11 May 2016 05:23:01 -0000 Github user parthchandra commented on the pull request: https://github.com/apache/drill/pull/491#issuecomment-218364635 Minor comments. Otherwise looks good. +1 Note the doc impact. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---