drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4199: Add Support for HBase 1.X
Date Mon, 30 May 2016 00:53:15 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/443#discussion_r65015118
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseStoragePlugin.java
---
    @@ -21,34 +21,36 @@
     import java.util.Set;
     
     import org.apache.calcite.schema.SchemaPlus;
    -
     import org.apache.drill.common.JSONOptions;
     import org.apache.drill.exec.ops.OptimizerRulesContext;
     import org.apache.drill.exec.server.DrillbitContext;
     import org.apache.drill.exec.store.AbstractStoragePlugin;
     import org.apache.drill.exec.store.SchemaConfig;
     import org.apache.drill.exec.store.StoragePluginOptimizerRule;
    +import org.apache.hadoop.conf.Configuration;
    +import org.apache.hadoop.hbase.client.Connection;
     
     import com.fasterxml.jackson.core.type.TypeReference;
     import com.fasterxml.jackson.databind.ObjectMapper;
     import com.google.common.collect.ImmutableSet;
     
     public class HBaseStoragePlugin extends AbstractStoragePlugin {
    -  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(HBaseStoragePlugin.class);
    +  private static final HBaseConnectionManager hbaseConnectionManager = HBaseConnectionManager.INSTANCE;
    --- End diff --
    
    Any reason you use static here as opposed to one per storage plugin instance? I suppose
this reduces overhead in the case of multiple plugin instances to a single target but generally,
I'd be inclined to just have an instance per plugin.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message