drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4693: Ensure final column re-ordering is...
Date Thu, 26 May 2016 01:00:31 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/508#discussion_r64677891
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ProjectPrel.java
---
    @@ -81,6 +83,18 @@ public SelectionVectorMode getEncoding() {
     
       @Override
       public boolean needsFinalColumnReordering() {
    +    for (RexNode expr : this.exps) {
    +      if (expr.getKind() == SqlKind.OTHER_FUNCTION &&
    +          expr instanceof RexCall &&
    +          ((RexCall) expr).getOperator().getName().equalsIgnoreCase("CONVERT_FROMJSON"))
{
    --- End diff --
    
    Will add a comment.  You should probably file a JIRA for the NPE. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message