drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hnfgns <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4690: CORS in REST API
Date Wed, 25 May 2016 18:41:52 GMT
Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64629211
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -110,6 +110,7 @@ drill.exec: {
       http: {
         enabled: true,
         ssl_enabled: false,
    +    cors_enabled: true,
    --- End diff --
    
    perhaps we should consider extending cors configuration with 
    ```
    http: {
      cors: {
        enabled: true,
        allowedOrigins: ['*.mydomain.com', '*.someother.net'], --> configures Access-Control-Allow-Origin
        allowedMethods: ['option', 'get', 'post', 'some-other'], --> configures  Access-Control-Allow-Methods
        allowedHeaders: ['some-allowed-header'], --> configures Access-Control-Expose-Headers

        credentials: true | false -- >  configures Access-Control-Allow-Credentials
      }
    }
    ```
    I am probably missing few in the list but I find these options essential.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message