drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4690: CORS in REST API
Date Wed, 25 May 2016 16:17:21 GMT
Github user laurentgo commented on a diff in the pull request:

    https://github.com/apache/drill/pull/507#discussion_r64603706
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
    @@ -159,6 +163,14 @@ public void start() throws Exception {
           servletContextHandler.setSessionHandler(createSessionHandler(servletContextHandler.getSecurityHandler()));
         }
     
    +    if (config.getBoolean(ExecConstants.HTTP_ENABLE_CORS)) {
    +      FilterHolder cors = servletContextHandler.addFilter(CrossOriginFilter.class, "/*",
EnumSet.of(DispatcherType.REQUEST));
    --- End diff --
    
    Not so much experience regarding CORS, but do we want to apply it to any resource, or
just the REST API, or maybe a subset of those?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message