drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4514 : Add describe schema <schema_name>...
Date Mon, 23 May 2016 22:20:13 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/436#discussion_r64299337
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java
---
    @@ -25,23 +25,27 @@
      *  - location which is a path.
      *  - writable flag to indicate whether the location supports creating new tables.
      *  - default storage format for new tables created in this workspace.
    + *  - physicalLocation is full path to workspace
      */
     @JsonIgnoreProperties(value = {"storageformat"})
     public class WorkspaceConfig {
     
       /** Default workspace is a root directory which supports read, but not write. */
    -  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", false, null);
    +  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", false, null,
null);
     
       private final String location;
       private final boolean writable;
       private final String defaultInputFormat;
    +  private final String physicalLocation;
     
       public WorkspaceConfig(@JsonProperty("location") String location,
                              @JsonProperty("writable") boolean writable,
    -                         @JsonProperty("defaultInputFormat") String defaultInputFormat)
{
    +                         @JsonProperty("defaultInputFormat") String defaultInputFormat,
    +                         @JsonProperty("physicalLocation") String physicalLocation) {
         this.location = location;
         this.writable = writable;
         this.defaultInputFormat = defaultInputFormat;
    +    this.physicalLocation = physicalLocation;
    --- End diff --
    
    WorkspaceConfig already has "location". Why do you prefer adding a new "physicalLocation"?
Is it possible to use "location" in stead?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message