drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4679: When convert() functions are prese...
Date Fri, 20 May 2016 19:00:20 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/504#discussion_r64091394
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
    @@ -146,6 +159,27 @@ protected IterOutcome doWork() {
               if (next == IterOutcome.OUT_OF_MEMORY) {
                 outOfMemory = true;
                 return next;
    +          } else if (next == IterOutcome.NONE) {
    +            // since this is first batch and we already got a NONE, need to set up the
schema
    +
    +            //allocate vv in the allocationVectors.
    +            for (final ValueVector v : this.allocationVectors) {
    --- End diff --
    
    The doAlloc() was calling incoming.getRecordCount() which would fail for empty batches,
so I did not use it but I can modify doAlloc to take the count parameter and have everyone
call the modified version.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message