drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4679: When convert() functions are prese...
Date Fri, 20 May 2016 15:55:41 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/504#discussion_r64064412
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
    @@ -136,6 +145,10 @@ public VectorContainer getOutgoingContainer() {
     
       @Override
       protected IterOutcome doWork() {
    +    if (wasNone) {
    +      return IterOutcome.NONE;
    +    }
    +
         int incomingRecordCount = incoming.getRecordCount();
     
         if (first && incomingRecordCount == 0) {
    --- End diff --
    
    The new logic will handle the case for Project's first outgoing batch. Not sure whether
Drill works properly after the first batch getting data and building the schema, but the next
incoming batch contains empty result. We may treat as a separate issue for further investigation.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message