drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-1328: Support table statistics
Date Wed, 18 May 2016 23:16:30 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/425#discussion_r63799668
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillJoinRelBase.java
---
    @@ -94,9 +97,39 @@ public RelOptCost computeSelfCost(RelOptPlanner planner) {
       public double getRows() {
         if (this.condition.isAlwaysTrue()) {
           return joinRowFactor * this.getLeft().getRows() * this.getRight().getRows();
    -    } else {
    -      return joinRowFactor * Math.max(this.getLeft().getRows(), this.getRight().getRows());
         }
    +
    +    int[] joinFields = new int[2];
    +
    +    LogicalJoin jr = new LogicalJoin(
    +        this.getCluster(),
    +        this.getTraitSet(),
    +        this.getLeft(),
    +        this.getRight(),
    +        this.getCondition(),
    +        this.getJoinType(),
    +        this.getVariablesStopped(),
    +        false /* TODO - verify if this the correct value */,
    --- End diff --
    
    Does this need to be addressed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message