drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4676: Foreman.moveToState can block fore...
Date Mon, 16 May 2016 23:42:35 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/503#discussion_r63444805
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -296,7 +295,7 @@ public void run() {
            * would wait on the cancelling thread to signal a resume and the cancelling thread
would wait on the Foreman
            * to accept events.
            */
    -      acceptExternalEvents.countDown();
    +      stateSwitch.start();
    --- End diff --
    
    that is true indeed, I didn't notice the Foreman was also using the event queue before
it counted down the latch. I will update the fix to respect this behavior


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message