drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4676: Foreman.moveToState can block fore...
Date Sun, 15 May 2016 17:17:29 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/503#discussion_r63294968
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -115,6 +115,8 @@
       private static final ObjectMapper MAPPER = new ObjectMapper();
       private static final long RPC_WAIT_IN_MSECS_PER_FRAGMENT = 5000;
     
    +  private Thread myThreadRef; // Thread that is currently executing the Foreman.
    --- End diff --
    
    I think you need either volatile or an atomic reference here since moveToState can be
executed by a thread other than the one running the fragment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message