drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4514 : Add describe schema <schema_name>...
Date Thu, 12 May 2016 00:43:16 GMT
Github user jinfengni commented on the pull request:

    https://github.com/apache/drill/pull/436#issuecomment-218630539
  
    The patch will show "schema_name, location" for "describe schema xxx" when it applied
to file system schema. I'm not sure why you only want to make it work for file system schema,
and return "information not available" for other schema. Also, what's the reason to only show
"location"? What if we add support for other schemas, and will "location" still make sense
for non-filesystem schema?
    
    To me, it would make more sense to return all the properties of schema for "describe schema/database",
as a JSON format string.  The properties could be anything defined in the schema. For file
system schema, it could be location, whether writable, default input format, etc. For other
schemas, there would be schema-dependent properties.  In case we add new properties to schema
in later release, there is no need to change the implementation of "describe schema".  In
other words, "describe schema/database" should return the content shown in webui storage tab
for that particular schema. 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message