drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3474: Add implicit file columns support
Date Wed, 11 May 2016 05:19:36 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/491#discussion_r62793098
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java
---
    @@ -324,6 +324,11 @@ protected boolean setupNewSchema() throws SchemaChangeException {
                   if (name == EMPTY_STRING) {
                     continue;
                   }
    +
    --- End diff --
    
    This has a major documentation impact since there is a change in the DIR columns returned
in a star query. Please make a note of this in the JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message