drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4642: Remove customized RexBuilder.ensur...
Date Wed, 04 May 2016 18:01:24 GMT
Github user jinfengni commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestFunctionsWithTypeExpoQueries.java
    @@ -213,7 +221,7 @@ public void tesIsNull() throws Exception {
         List<Pair<SchemaPath, TypeProtos.MajorType>> expectedSchema = Lists.newArrayList();
         TypeProtos.MajorType majorType = TypeProtos.MajorType.newBuilder()
    -        .setMode(TypeProtos.DataMode.REQUIRED)
    +        .setMode(TypeProtos.DataMode.OPTIONAL)
    --- End diff --
    why do you have to change the expected result for this query? Should  "r_name is null"
be a required type?  

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message