Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: hnfgns <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-368-drill@git.apache.org>
In-Reply-To: <git-pr-368-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4132 Ability to submit simple type
 of ph...
Content-Type: text/plain
Message-Id: <20160428195542.348D1DFDCF@git1-us-west.apache.org>
Date: Thu, 28 Apr 2016 19:55:42 +0000 (UTC)

Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/368#discussion_r61492206
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/user/PlanSplitter.java ---
    @@ -0,0 +1,142 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.work.user;
    +
    +import java.util.List;
    +
    +import org.apache.drill.exec.ops.QueryContext;
    +import org.apache.drill.exec.physical.PhysicalPlan;
    +import org.apache.drill.exec.physical.base.PhysicalOperator;
    +import org.apache.drill.exec.planner.fragment.Fragment;
    +import org.apache.drill.exec.planner.fragment.MakeFragmentsVisitor;
    +import org.apache.drill.exec.planner.fragment.SimpleParallelizer;
    +import org.apache.drill.exec.planner.fragment.contrib.SimpleParallelizerMultiPlans;
    +import org.apache.drill.exec.planner.sql.DrillSqlWorker;
    +import org.apache.drill.exec.proto.BitControl.PlanFragment;
    +import org.apache.drill.exec.proto.UserBitShared.DrillPBError;
    +import org.apache.drill.exec.proto.UserBitShared.QueryId;
    +import org.apache.drill.exec.proto.UserBitShared.QueryResult.QueryState;
    +import org.apache.drill.exec.proto.UserProtos.GetQueryPlanFragments;
    +import org.apache.drill.exec.proto.UserProtos.QueryPlanFragments;
    +import org.apache.drill.exec.rpc.user.UserServer.UserClientConnection;
    +import org.apache.drill.exec.server.DrillbitContext;
    +import org.apache.drill.exec.util.MemoryAllocationUtilities;
    +import org.apache.drill.exec.util.Pointer;
    +import org.apache.drill.exec.util.Utilities;
    +import org.apache.drill.exec.work.QueryWorkUnit;
    +
    +import com.google.common.collect.Lists;
    +
    +/**
    + * Helper class to return PlanFragments based on the query plan
    + * or based on split query plan
    + *
    + */
    +public class PlanSplitter {
    +  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(PlanSplitter.class);
    +
    +  private static PlanSplitter s_instance = new PlanSplitter();
    +
    +  private PlanSplitter() {
    +
    +  }
    +
    +  public static PlanSplitter getInstance() {
    +    return s_instance;
    --- End diff --
    
    This seems a very cheap object used once per query. Why to make it singleton? We should create it in the stack/heap as we need.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---