Return-Path: 
 <dev-return-22028-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6572919001
	for <apmail-drill-dev-archive@www.apache.org>;
 Tue, 26 Apr 2016 17:41:00 +0000 (UTC)
Received: (qmail 8794 invoked by uid 500); 26 Apr 2016 17:41:00 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 8747 invoked by uid 500); 26 Apr 2016 17:41:00 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 8736 invoked by uid 99); 26 Apr 2016 17:40:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 17:40:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id AA61FDFE5F; Tue, 26 Apr 2016 17:40:59 +0000 (UTC)
From: parthchandra <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-454-drill@git.apache.org>
In-Reply-To: <git-pr-454-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-2100: Added deleting temporary
 spill dir...
Content-Type: text/plain
Message-Id: <20160426174059.AA61FDFE5F@git1-us-west.apache.org>
Date: Tue, 26 Apr 2016 17:40:59 +0000 (UTC)

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/454#discussion_r61130563
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java ---
    @@ -116,6 +119,7 @@
       private boolean first = true;
       private int targetRecordCount;
       private final String fileName;
    +  private Set<Path> currSpillDirs = new TreeSet<>();
    --- End diff --
    
    minor - A simple list will do here.  Also consider using Guava collections.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---