Return-Path: 
 <dev-return-22017-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id ED2FD19DAC
	for <apmail-drill-dev-archive@www.apache.org>;
 Tue, 26 Apr 2016 16:50:52 +0000 (UTC)
Received: (qmail 46688 invoked by uid 500); 26 Apr 2016 16:50:52 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 46638 invoked by uid 500); 26 Apr 2016 16:50:52 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 46627 invoked by uid 99); 26 Apr 2016 16:50:52 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 16:50:52 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 5E6F5DFF30; Tue, 26 Apr 2016 16:50:52 +0000 (UTC)
From: sudheeshkatkam <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-482-drill@git.apache.org>
In-Reply-To: <git-pr-482-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4604: Generate warning on Web UI
 if dril...
Content-Type: text/plain
Message-Id: <20160426165052.5E6F5DFF30@git1-us-west.apache.org>
Date: Tue, 26 Apr 2016 16:50:52 +0000 (UTC)

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r61121843
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java ---
    @@ -55,44 +59,89 @@ public Viewable getStats() {
       @GET
       @Path("/stats.json")
       @Produces(MediaType.APPLICATION_JSON)
    -  public List<Stat> getStatsJSON() {
    -    List<Stat> stats = Lists.newLinkedList();
    -    stats.add(new Stat("Number of Drill Bits", work.getContext().getBits().size()));
    -    int number = 0;
    -    for (CoordinationProtos.DrillbitEndpoint bit : work.getContext().getBits()) {
    -      String initialized = bit.isInitialized() ? " initialized" : " not initialized";
    -      stats.add(new Stat("Bit #" + number, bit.getAddress() + initialized));
    -      ++number;
    +  public Stats getStatsJSON() {
    +    String version = work.getContext().getOptionManager().getOption(ExecConstants.CLUSTER_VERSION).string_val;
    --- End diff --
    
    Hmm there's a problem then.. Default values (`DrillVersionInfo.getVersion()`) are not put in the persistent store, meaning each Drillbit would start with its own version, and the intended warning will not be generated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---