Return-Path: 
 <dev-return-21965-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 98E6E198CD
	for <apmail-drill-dev-archive@www.apache.org>;
 Thu, 21 Apr 2016 14:03:39 +0000 (UTC)
Received: (qmail 18594 invoked by uid 500); 21 Apr 2016 14:03:39 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 18547 invoked by uid 500); 21 Apr 2016 14:03:39 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 18536 invoked by uid 99); 21 Apr 2016 14:03:39 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 14:03:39 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id D187FDFD7B; Thu, 21 Apr 2016 14:03:38 +0000 (UTC)
From: vdiravka <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-454-drill@git.apache.org>
In-Reply-To: <git-pr-454-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-2100: Added deleting temporary
 spill dir...
Content-Type: text/plain
Message-Id: <20160421140338.D187FDFD7B@git1-us-west.apache.org>
Date: Thu, 21 Apr 2016 14:03:38 +0000 (UTC)

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/454#discussion_r60585364
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java ---
    @@ -554,7 +572,18 @@ public BatchGroup mergeAndSpill(LinkedList<BatchGroup> batchGroups) throws Schem
         c1.buildSchema(BatchSchema.SelectionVectorMode.NONE);
         c1.setRecordCount(count);
     
    -    String outputFile = Joiner.on("/").join(dirs.next(), fileName, spillCount++);
    +    String spillDir = dirs.next();
    +    Path currSpillPath = new Path(Joiner.on("/").join(spillDir, fileName));
    +    currSpillDirs.add(currSpillPath);
    +    String outputFile = Joiner.on("/").join(currSpillPath, spillCount++);
    +    try {
    +        fs.deleteOnExit(currSpillPath);
    +    } catch (IOException e) {
    +        // since this is meant to be used in a batches's spilling, we don't propagate the exception
    +        final String message = "Unable to mark spill directory \"" + currSpillPath + "\" to delete on exit";
    +        System.err.println(message + '.');
    --- End diff --
    
    Updated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---