Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2C711195B2 for ; Mon, 11 Apr 2016 21:00:49 +0000 (UTC) Received: (qmail 40375 invoked by uid 500); 11 Apr 2016 21:00:49 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 40324 invoked by uid 500); 11 Apr 2016 21:00:48 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 40310 invoked by uid 99); 11 Apr 2016 21:00:48 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 21:00:48 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9370CDFC6E; Mon, 11 Apr 2016 21:00:48 +0000 (UTC) From: chunhui-shi To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request: DRILL-4143: Fix inconsistency in writing metad... Content-Type: text/plain Message-Id: <20160411210048.9370CDFC6E@git1-us-west.apache.org> Date: Mon, 11 Apr 2016 21:00:48 +0000 (UTC) Github user chunhui-shi commented on the pull request: https://github.com/apache/drill/pull/470#issuecomment-208558947 This createMeta is only called in RefreshMetadataHandler using a DrillFileSystem created locally without impersonation, so the filesystem used in createMeta needs no change. Meanwhile the metadata in readBlockMeta is using the filesystem created in ParquetGroupScan with impersonation. So the fix is to focus on this filesystem instance and replace it with a filesystem instance of process permission to keep consistent with cretaeMeta and other places. As to the recursive permission check, as we discussed, it is a security issue and not a functional issue like this one, and there are multiple related JIRAs related to metadata too. we can fix them together later with a thorough patch. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---