Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7657219F2A for ; Fri, 8 Apr 2016 00:57:15 +0000 (UTC) Received: (qmail 92394 invoked by uid 500); 8 Apr 2016 00:57:15 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 92332 invoked by uid 500); 8 Apr 2016 00:57:14 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 92321 invoked by uid 99); 8 Apr 2016 00:57:14 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Apr 2016 00:57:14 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 91742DFC55; Fri, 8 Apr 2016 00:57:14 +0000 (UTC) From: amansinha100 To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ... Content-Type: text/plain Message-Id: <20160408005714.91742DFC55@git1-us-west.apache.org> Date: Fri, 8 Apr 2016 00:57:14 +0000 (UTC) Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/430#issuecomment-207153608 @jacques-n regarding re-implementation, agree with the general concern; however in this case the core logic is directly taken from the java based murmur hash implementation (compared to the XXHash that was ported from C). The OpenHFT discussion happened a little late in the cycle but in any case it seems fairly young project that is run by 1 company. We could re-visit it in future. When discussing the hash functions with @chunhui-shi we really want to get to a stage where Drill could allow a few different hash functions/library to exist and choose based on an external setting. Regarding performance, we have done a couple of rounds of testing but likely will do another one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---