Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: amansinha100 <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-468-drill@git.apache.org>
In-Reply-To: <git-pr-468-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4589: Reduce planning time for
 file syst...
Content-Type: text/plain
Message-Id: <20160407182849.F212EDFC74@git1-us-west.apache.org>
Date: Thu,  7 Apr 2016 18:28:49 +0000 (UTC)

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/468#discussion_r58921279
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/DFSDirPartitionLocation.java ---
    @@ -0,0 +1,70 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +/**
    + * Class defines a single partition corresponding to a directory in a DFS table.
    + */
    +package org.apache.drill.exec.planner;
    +
    +
    +import com.google.common.collect.Lists;
    +
    +import java.util.Collection;
    +import java.util.List;
    +
    +public class DFSDirPartitionLocation implements PartitionLocation {
    +  private final Collection<PartitionLocation> subPartitions;
    --- End diff --
    
    Can this collection be a mix of directory partition locations as well as file partition locations ?  It has become a little confusing to keep track of the distinction between the two since the term PartitionLocation is overloaded.   Can you add appropriate javadoc to clarify ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---