Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: vkorukanti <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-462-drill@git.apache.org>
In-Reply-To: <git-pr-462-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4539: Add support for Null
 Equality Join...
Content-Type: text/plain
Message-Id: <20160406170250.40C1FDFC6C@git1-us-west.apache.org>
Date: Wed,  6 Apr 2016 17:02:50 +0000 (UTC)

Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/462#discussion_r58742916
  
    --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java ---
    @@ -215,6 +192,36 @@ public void eval() {
         }
       }
     
    +  <#-- IS_DISTINCT_FROM function -->
    +  @FunctionTemplate(names = {"is_distinct_from", "is distinct from" },
    --- End diff --
    
    If adding new functions is a concern, I can make the ```RelOptUtil#splitJoinCondition``` to identify rewritten ```IS NOT DISTINCT FROM``` functions also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---