Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: arina-ielchiieva <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-445-drill@git.apache.org>
In-Reply-To: <git-pr-445-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4523: Disallow using loopback
 address in...
Content-Type: text/plain
Message-Id: <20160405085719.4B63FDFCDF@git1-us-west.apache.org>
Date: Tue,  5 Apr 2016 08:57:19 +0000 (UTC)

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/445#discussion_r58505187
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java ---
    @@ -177,6 +182,13 @@ public void run() {
         });
       }
     
    +  /** If in distributed mode, disallow using loopback address to register new drillbit. */
    +  private void checkLoopbackAddress(String address) throws DrillbitStartupException, UnknownHostException {
    +    if (isDistributedMode && InetAddress.getByName(address).isLoopbackAddress()) {
    +      throw new DrillbitStartupException("Loopback address is not allowed to be registered in distributed mode");
    --- End diff --
    
    Sounds reasonable. Updated PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---