drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Altekruse (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (DRILL-4448) Specification of Ordering (ASC, DESC) on a sort plan node uses Strings for construction, should also allow for use of the corresponding Calcite Enums
Date Wed, 20 Apr 2016 18:13:25 GMT

     [ https://issues.apache.org/jira/browse/DRILL-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Altekruse resolved DRILL-4448.
------------------------------------
    Resolution: Fixed

Fixed in 1d1acc09ec30167f0653d99cee6f30c7b1413859

> Specification of Ordering (ASC, DESC) on a sort plan node uses Strings for construction,
should also allow for use of the corresponding Calcite Enums
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-4448
>                 URL: https://issues.apache.org/jira/browse/DRILL-4448
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Jason Altekruse
>
> Small change to provide a cleaner interface when constructing sort configurations in
tests. The current class mixes together two tasks, converting between the strings we chose
to put in the plans (ASC, DESC) and the Calcite enums, as well as validating the allowed values.
Calcite has several values that we do not currently use like STRICTLY_ASCENDING/DESCENDING
and CLUSTERED. We can break these two tasks apart to allow for construction directly from
the Enum, but still provide validation for only the drill allowed values.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message