drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chunhui Shi <c...@maprtech.com>
Subject Re: [GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...
Date Fri, 01 Apr 2016 01:55:06 GMT
Thanks for pointing to openHFT. I went through multiple Java
implementations including this one. The reason I decided to use smhasher as
the source of truth was, the smhasher implementation includes comprehensive
tests to cover the attributes for measuring goodness of a non-cryptographic
hash function. And these attributes are subtle and could be found out to be
a problem maybe only on certain lengths of input. So when I looked at these
implementations, I check what tests they have done first. And  there is no
such tests(test multiple attributes and lengths) in these Java
implementations to prove the hash functions are correct or good. So I
decided to start from smhasher implementations and used the results
generated from smhasher to verify any other(including drill's)
implementation.




On Wed, Mar 30, 2016 at 7:53 PM, jacques-n <git@git.apache.org> wrote:

> Github user jacques-n commented on the pull request:
>
>     https://github.com/apache/drill/pull/430#issuecomment-203726680
>
>     Did you consider leveraging this library:
>
>     https://github.com/OpenHFT/Zero-Allocation-Hashing
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message