drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vdiravka <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3894: Upgrade functions MaxDir, MinDir.....
Date Thu, 28 Apr 2016 15:58:34 GMT
Github user vdiravka commented on the pull request:

    https://github.com/apache/drill/pull/467#issuecomment-215476544
  
    I used the same approach like in lpad .. functions. You can use Query Directory Functions
with filename param or without it.
    And for code cleaning I've replaced `MaxDirOnePar` with `MaxDir`, `MaxDirTwoPar` with
`MaxDirTwoArg` like in the lpad functions and I've replaced `parameterAmount==2` label with
`functionClassName?ends_with("TwoArg")`. 
    Also I've added UTest for new Query Directory Functions implementations.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message