drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yufeldman <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4132 Ability to submit simple type of ph...
Date Wed, 27 Apr 2016 23:42:56 GMT
Github user yufeldman commented on a diff in the pull request:

    https://github.com/apache/drill/pull/368#discussion_r61355122
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -419,6 +425,64 @@ private void runPhysicalPlan(final PhysicalPlan plan) throws ExecutionSetupExcep
         logger.debug("Fragments running.");
       }
     
    +  /**
    +   * This is a helper method to run query based on the list of PlanFragment that were
planned
    +   * at some point of time
    +   * @param fragmentsList
    +   * @throws ExecutionSetupException
    +   */
    +  private void runFragment(List<PlanFragment> fragmentsList) throws ExecutionSetupException
{
    +    // need to set QueryId, MinorFragment for incoming Fragments
    +    PlanFragment rootFragment = null;
    +    boolean isFirst = true;
    +    final List<PlanFragment> planFragments = Lists.newArrayList();
    +    final int fragmentsCount = fragmentsList.size();
    +    for (PlanFragment myFragment : fragmentsList) {
    +      final FragmentHandle handle = myFragment.getHandle();
    +      // for split plan number of minor fragments will be always one,
    +      // but minor fragmentId may not be 0, as it is one of the minor fragments from
split plan
    +      final int minorFragment = (fragmentsCount == 1) ? 0 : handle.getMinorFragmentId();
    --- End diff --
    
    good point


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message