drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hnfgns <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4132 Ability to submit simple type of ph...
Date Wed, 27 Apr 2016 22:26:37 GMT
Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/368#discussion_r61347587
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/Utilities.java ---
    @@ -17,13 +17,27 @@
      */
     package org.apache.drill.exec.util;
     
    +import java.util.LinkedList;
    +import java.util.List;
    +
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.exec.ExecConstants;
     import org.apache.drill.exec.expr.fn.impl.DateUtility;
    +import org.apache.drill.exec.memory.RootAllocatorFactory;
     import org.apache.drill.exec.ops.FragmentContext;
    +import org.apache.drill.exec.ops.QueryContext;
    +import org.apache.drill.exec.physical.PhysicalPlan;
    +import org.apache.drill.exec.physical.base.PhysicalOperator;
    +import org.apache.drill.exec.physical.config.ExternalSort;
     import org.apache.drill.exec.proto.BitControl.QueryContextInformation;
     import org.apache.drill.exec.proto.ExecProtos;
     import org.apache.drill.exec.proto.helper.QueryIdHelper;
    +import org.apache.drill.exec.server.options.OptionManager;
     
     public class Utilities {
    --- End diff --
    
    I am against the anti-pattern of a generic Utilities class. It won't take too long for
us to turn into a junk yard of code :) I would propose that we externalize the functionality
here to its relevant utility class like SortUtils or similar.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message