drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hnfgns <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4132 Ability to submit simple type of ph...
Date Wed, 27 Apr 2016 22:23:22 GMT
Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/368#discussion_r61347199
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java
---
    @@ -137,4 +142,9 @@ protected void finalizeConnection(BitToUserHandshake handshake, BasicClientWithC
       public ProtobufLengthDecoder getDecoder(BufferAllocator allocator) {
         return new UserProtobufLengthDecoder(allocator, OutOfMemoryHandler.DEFAULT_INSTANCE);
       }
    +
    +  public DrillRpcFuture<QueryPlanFragments> submitPlanQuery(
    --- End diff --
    
    Should we consider renaming this to planQuery(...) and add a small comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message