drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2100: Added deleting temporary spill dir...
Date Tue, 26 Apr 2016 17:40:59 GMT
Github user parthchandra commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java
    @@ -116,6 +119,7 @@
       private boolean first = true;
       private int targetRecordCount;
       private final String fileName;
    +  private Set<Path> currSpillDirs = new TreeSet<>();
    --- End diff --
    minor - A simple list will do here.  Also consider using Guava collections.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message