drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4604: Generate warning on Web UI if dril...
Date Tue, 26 Apr 2016 16:51:11 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/482#discussion_r61121895
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java
---
    @@ -55,44 +59,89 @@ public Viewable getStats() {
       @GET
       @Path("/stats.json")
       @Produces(MediaType.APPLICATION_JSON)
    -  public List<Stat> getStatsJSON() {
    -    List<Stat> stats = Lists.newLinkedList();
    -    stats.add(new Stat("Number of Drill Bits", work.getContext().getBits().size()));
    -    int number = 0;
    -    for (CoordinationProtos.DrillbitEndpoint bit : work.getContext().getBits()) {
    -      String initialized = bit.isInitialized() ? " initialized" : " not initialized";
    -      stats.add(new Stat("Bit #" + number, bit.getAddress() + initialized));
    -      ++number;
    +  public Stats getStatsJSON() {
    +    String version = work.getContext().getOptionManager().getOption(ExecConstants.CLUSTER_VERSION).string_val;
    +
    +    Map<String, Object> props = Maps.newLinkedHashMap();
    +    props.put("Cluster Version", version);
    +    props.put("Number of Drill Bits", work.getContext().getBits().size());
    +    CoordinationProtos.DrillbitEndpoint currentEndpoint = work.getContext().getEndpoint();
    +    String address = currentEndpoint.getAddress();
    +    props.put("Data Port Address", address + ":" + currentEndpoint.getDataPort());
    +    props.put("User Port Address", address + ":" + currentEndpoint.getUserPort());
    +    props.put("Control Port Address", address + ":" + currentEndpoint.getControlPort());
    +    props.put("Maximum Direct Memory", DrillConfig.getMaxDirectMemory());
    +
    +    return new Stats(props, collectBits(version));
    +  }
    +
    +  private Collection<Bit> collectBits(String version) {
    +    Set<Bit> bits = Sets.newTreeSet();
    +    for (CoordinationProtos.DrillbitEndpoint endpoint : work.getContext().getBits())
{
    +      boolean versionMatch = version.equals(endpoint.getVersion());
    +      Bit bit = new Bit(endpoint.getAddress(), endpoint.isInitialized(), endpoint.getVersion(),
versionMatch);
    +      bits.add(bit);
         }
    -    stats.add(new Stat("Data Port Address", work.getContext().getEndpoint().getAddress()
+
    -      ":" + work.getContext().getEndpoint().getDataPort()));
    -    stats.add(new Stat("User Port Address", work.getContext().getEndpoint().getAddress()
+
    -      ":" + work.getContext().getEndpoint().getUserPort()));
    -    stats.add(new Stat("Control Port Address", work.getContext().getEndpoint().getAddress()
+
    -      ":" + work.getContext().getEndpoint().getControlPort()));
    -    stats.add(new Stat("Maximum Direct Memory", DrillConfig.getMaxDirectMemory()));
    -
    -    return stats;
    +    return bits;
       }
     
       @XmlRootElement
    -  public class Stat {
    -    private String name;
    -    private Object value;
    +  public class Stats {
    --- End diff --
    
    static class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message