drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...
Date Tue, 12 Apr 2016 20:13:15 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/463#discussion_r59445000
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RequestIdMap.java ---
    @@ -84,7 +115,7 @@ public void operationComplete(ChannelFuture future) throws Exception
{
           if (!future.isSuccess()) {
             removeFromMap(coordinationId);
             if (future.channel().isActive()) {
    -           throw new RpcException("Future failed") ;
    +          throw new RpcException("Future failed");
    --- End diff --
    
    This has existed since this commit (Sept 2013): https://github.com/apache/drill/commit/3f101aabd05f174e8bfc9dbdd2590066a1e937f4
    
    I'm not inclined to change it in this patch as it seems out of scope. The change probably
makes sense but let's explore in a different jira to ensure we're thinking through the ramifications.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message