drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chunhui-shi <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4143: Fix inconsistency in writing metad...
Date Mon, 11 Apr 2016 21:00:48 GMT
Github user chunhui-shi commented on the pull request:

    https://github.com/apache/drill/pull/470#issuecomment-208558947
  
    This createMeta is only called in RefreshMetadataHandler using a DrillFileSystem created
locally without impersonation, so the filesystem used in createMeta needs no change. Meanwhile
the metadata in readBlockMeta is using the filesystem created in ParquetGroupScan with impersonation.
So the fix is to focus on this filesystem instance and replace it with a filesystem instance
of process permission to keep consistent with cretaeMeta and other places.
    
    As to the recursive permission check, as we discussed, it is a security issue and not
a functional issue like this one, and there are multiple related JIRAs related to metadata
too. we can fix them together later with a thorough patch. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message