drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yufeldman <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4596: Drill should do version check amon...
Date Fri, 08 Apr 2016 17:50:28 GMT
Github user yufeldman commented on a diff in the pull request:

    https://github.com/apache/drill/pull/474#discussion_r59063793
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
    @@ -207,6 +209,28 @@ private void javaPropertiesToSystemOptions() {
       }
     
       /**
    +   * Disallow registering drillbit when:
    +   * 1. version is unknown;
    +   * 2. drillbit with different version has been already registered.
    --- End diff --
    
    What if you first DrillBit registered had "bad" version? Somebody would have to bring
it down, so others can start?
    Should it be (at least) option to have soft enforcement, rather than just hard enforcement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message