drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4237 DRILL-4478 fully implement hash to ...
Date Fri, 08 Apr 2016 00:00:44 GMT
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/430#issuecomment-207142922
  
    @amansinha100, I trust your feedback on the code review. 
    
    I'm a little worried that we continue to reimplement things that exist externally and
then have to pay more maintenance than we can afford. It may make sense to have our own hash
implementations rather than use a shared library, I really don't know. I just want to make
sure we're evaluating the options rather than just building our own. For example, if we started
now, I would be inclined to leverage grpc rather than build our own rpc layer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message