drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...
Date Thu, 07 Apr 2016 06:55:25 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/463#discussion_r58826205
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/RemoteConnection.java ---
    @@ -121,17 +115,72 @@ public void disable() {
         }
       }
     
    -  private class BackPressureHandler extends ChannelInboundHandlerAdapter{
    +  private class BackPressureHandler extends ChannelInboundHandlerAdapter {
     
         @Override
         public void channelWritabilityChanged(ChannelHandlerContext ctx) throws Exception
{
    -//      logger.debug("Channel writability changed.", ctx.channel().isWritable());
           writeManager.setWritable(ctx.channel().isWritable());
           ctx.fireChannelWritabilityChanged();
         }
     
       }
     
    +  /**
    +   * For incoming messages, remove the outcome listener and return it. Can only be done
once per coordinationId.
    --- End diff --
    
    > can only be done once per coordinationId
    
    Could this be slightly misleading ? `requestIdMap` recycles coordinationIds, so technically
this can be called **multiple times** per coordinationId if the Drillbit runs long enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message