drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3714: Avoid cascading disconnection when...
Date Thu, 07 Apr 2016 01:05:21 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/463#discussion_r58806604
  
    --- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java ---
    @@ -282,15 +283,19 @@ public void interrupted(final InterruptedException ex) {
     
       private class ClientHandshakeHandler extends AbstractHandshakeHandler<HANDSHAKE_RESPONSE>
{
     
    -    public ClientHandshakeHandler() {
    +    private final R connection;
    +
    +    public ClientHandshakeHandler(R connection) {
           super(BasicClient.this.handshakeType, BasicClient.this.handshakeParser);
    +      Preconditions.checkNotNull(connection);
    --- End diff --
    
    `this.connection = Preconditions.checkNotNull(connection);`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message