drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...
Date Wed, 06 Apr 2016 15:48:57 GMT
Github user amansinha100 commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java ---
    @@ -215,6 +192,36 @@ public void eval() {
    +  <#-- IS_DISTINCT_FROM function -->
    +  @FunctionTemplate(names = {"is_distinct_from", "is distinct from" },
    --- End diff --
    @vkorukanti, I want to clarify...if the query only had a join condition with IS_NOT_DISTINCT_FROM,
I would think it should work just with your convertlet changes, since both HashJoin and MergeJoin
handle this type of join condition.  Is the reason you had to implement the full comparator
codegen to handle more general types of comparisons ?  e.g in the SELECT list if I say  'SELECT
 a IS NOT DISTINCT FROM b'  ?    Suppose we had a convertlet that only preserved the IS (NOT)
DISTINCT FROM join condition, and defaulted to the Calcite rewrite using the CASE expression,
then we would not have to implement the full comparator. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message