drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...
Date Wed, 06 Apr 2016 15:39:36 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/462#discussion_r58728331
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
---
    @@ -169,4 +176,223 @@ private static boolean containIdentity(List<? extends RexNode>
exps,
         }
         return true;
       }
    +
    +  /**
    +   * Copied from {@link RelOptUtil#splitJoinCondition(RelNode, RelNode, RexNode, List,
List)}. Modified to rewrite
    --- End diff --
    
    Agree that we ideally should leverage the Calcite code..especially since this method is
pretty heavily used and modified periodically so keeping Drill's version of this method in
sync will be difficult. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message