drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...
Date Wed, 06 Apr 2016 02:53:31 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/462#discussion_r58645138
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java
---
    @@ -169,4 +176,223 @@ private static boolean containIdentity(List<? extends RexNode>
exps,
         }
         return true;
       }
    +
    +  /**
    +   * Copied from {@link RelOptUtil#splitJoinCondition(RelNode, RelNode, RexNode, List,
List)}. Modified to rewrite
    --- End diff --
    
    Is there a way to make this not copied? @julianhyde, any ideas for how to refactor common
stuff out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message