drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vkorukanti <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...
Date Tue, 05 Apr 2016 21:27:30 GMT
Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/461#discussion_r58617109
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java
---
    @@ -72,4 +80,56 @@ public String getTypeName() {
         return HiveStoragePluginConfig.NAME;
       }
     
    +  @Override
    +  public void visitTables(final RecordGenerator recordGenerator, final String schemaPath)
{
    +    final List<String> tableNames = Lists.newArrayList(getTableNames());
    +    List<org.apache.hadoop.hive.metastore.api.Table> tables;
    +    // Retries once if the first call to fetch the metadata fails
    +    synchronized(mClient) {
    +      try {
    +        tables = mClient.getTableObjectsByName(getName(), tableNames);
    --- End diff --
    
    Can you check if this API respects user permissions of tables? If yes, can you add few
tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message