drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3743: Fail active listeners if server co...
Date Tue, 05 Apr 2016 06:18:43 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/460#discussion_r58491456
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/QueryResultHandler.java
---
    @@ -189,20 +218,10 @@ private UserResultsListener newUserResultsListener(QueryId queryId)
{
           if ( null == resultsListener ) {
             resultsListener = bl;
           }
    -      // TODO:  Is there a more direct way to detect a Query ID in whatever state this
string comparison detects?
    -      if ( queryId.toString().isEmpty() ) {
    --- End diff --
    
    You removed this because it's impossible to receive a batch without a queryId, right ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message