drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...
Date Mon, 04 Apr 2016 10:53:44 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/445#discussion_r58358260
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
    @@ -177,6 +182,18 @@ public void run() {
         });
       }
     
    +  /** If we are in distributed mode, disallow using loopback address to register new
drillbit
    +   *  unless zookeeper is on the same node with drillbit. */
    +  private void checkLoopbackAddress(String address) throws DrillbitStartupException,
UnknownHostException {
    +    if (isDistributedMode) {
    +      String coordAddress = StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION),
":");
    +      if (!InetAddress.getByName(coordAddress).isLoopbackAddress()
    --- End diff --
    
    At some point, we wanted to allow loopback only if we have one node only but it's much
safer to disallow loopback in distributed mode at all. Updated pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message