drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From arina-ielchiieva <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4544: Improve error messages for REFRESH...
Date Fri, 01 Apr 2016 09:05:02 GMT
Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/448#discussion_r58179906
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java
---
    @@ -64,6 +65,11 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws ValidationException,
RelConv
           final SchemaPlus schema = findSchema(config.getConverter().getDefaultSchema(),
               refreshTable.getSchemaPath());
     
    +      if (schema == null) {
    +        return direct(false, "Storage plugin or workspace does not exist [%s]",
    --- End diff --
    
    In RefreshMetadataHandler all known exceptions are not thrown but sent as output. Ex:
    -----------+
    ok	summary
    -----------+
    false	Storage plugin or workspace does not exist dfs.incorrect
    -----------+
    The same is done when table doesn't exist or refresh is not supported.
    I suggest we use the same / exisitng logic to handle new error.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message