Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: sudheeshkatkam <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-429-drill@git.apache.org>
In-Reply-To: <git-pr-429-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4504: Create an event loop for
 each of [...
Content-Type: text/plain
Message-Id: <20160325075633.E9FEDDFC6E@git1-us-west.apache.org>
Date: Fri, 25 Mar 2016 07:56:33 +0000 (UTC)

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/429#discussion_r57426094
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java ---
    @@ -50,8 +52,12 @@
       public BootStrapContext(DrillConfig config, ScanResult classpathScan) {
         this.config = config;
         this.classpathScan = classpathScan;
    -    this.loop = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS), "BitServer-");
    -    this.loop2 = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS), "BitClient-");
    +    this.controlLoopGroup = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
    --- End diff --
    
    Done. I am hesitant to lower the control loop size until all blocking calls in handling requests are removed (e.g. cancelling an executor while fragment is starting up).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---